generated from amazon-archives/__template_Custom
-
Notifications
You must be signed in to change notification settings - Fork 396
Background server load #1775
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Background server load #1775
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1775 +/- ##
=======================================
Coverage ? 16.75%
=======================================
Files ? 213
Lines ? 20704
Branches ? 871
=======================================
Hits ? 3468
Misses ? 17236
Partials ? 0 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
chaynabors
previously requested changes
May 12, 2025
brandonskiser
previously approved these changes
May 12, 2025
brandonskiser
approved these changes
May 12, 2025
evanliu048
approved these changes
May 13, 2025
This was referenced May 14, 2025
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
#1466
Description of changes:
Enables background server load:
tools/listto the same level as prompts, which are also fetched in the background.q settings mcp.initTimeout. I have opted to not have this inmcp.jsonbecause this might conflict with how IDE interprets the config./toolsnow show servers still in loading.Removal of mcp_client crate:
Refinement of conversation invariant logic with regards to tool calls with incorrect names:
There are three scenarios in which intervention would be needed:
which case we would automatically resolve this tool call to its correct name. This will NOT
result in an error in its tool result. The intervention here is to substitute the partial name
with its full name.
could be referring to, in which case we WILL return an error in the tool result. The
intervention here is to substitute the ambiguous, partial name with a dummy.
substitute the non-existent tool name with a dummy.
List changed support for prompts and tools:
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.